Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle button for split tunneling #5554

Conversation

MaryamShaghaghi
Copy link
Contributor

@MaryamShaghaghi MaryamShaghaghi commented Dec 6, 2023


This change is Reviewable

@Pururun Pururun added the Android Issues related to Android label Dec 6, 2023
@MaryamShaghaghi MaryamShaghaghi force-pushed the enable-button-for-split-tunneling branch 5 times, most recently from 454a817 to e6d24c8 Compare December 7, 2023 14:18
@Boki91 Boki91 force-pushed the enable-button-for-split-tunneling branch from e6d24c8 to c52ee62 Compare December 7, 2023 14:38
@MaryamShaghaghi MaryamShaghaghi force-pushed the enable-button-for-split-tunneling branch 2 times, most recently from e38a230 to a7fe0fa Compare December 7, 2023 15:03
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MaryamShaghaghi)


android/app/src/main/kotlin/net/mullvad/mullvadvpn/viewmodel/SplitTunnelingViewModel.kt line 85 at r1 (raw file):

    }

    fun onShowAppList(show: Boolean) {

This should be changed to enableSplitTunneling or something similar.

Copy link
Contributor Author

@MaryamShaghaghi MaryamShaghaghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 8 of 10 files reviewed, 1 unresolved discussion (waiting on @Pururun)


android/app/src/main/kotlin/net/mullvad/mullvadvpn/viewmodel/SplitTunnelingViewModel.kt line 85 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

This should be changed to enableSplitTunneling or something similar.

Done.

@MaryamShaghaghi MaryamShaghaghi force-pushed the enable-button-for-split-tunneling branch from 364c147 to a5aa6fb Compare December 12, 2023 08:00
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun
Copy link
Contributor

Pururun commented Jan 3, 2024

Opened a new PR with the same commits here, just adjusted for compose navigation: #5641

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants