-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add toggle button for split tunneling #5554
Add toggle button for split tunneling #5554
Conversation
454a817
to
e6d24c8
Compare
e6d24c8
to
c52ee62
Compare
e38a230
to
a7fe0fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MaryamShaghaghi)
android/app/src/main/kotlin/net/mullvad/mullvadvpn/viewmodel/SplitTunnelingViewModel.kt
line 85 at r1 (raw file):
} fun onShowAppList(show: Boolean) {
This should be changed to enableSplitTunneling
or something similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 8 of 10 files reviewed, 1 unresolved discussion (waiting on @Pururun)
android/app/src/main/kotlin/net/mullvad/mullvadvpn/viewmodel/SplitTunnelingViewModel.kt
line 85 at r1 (raw file):
Previously, Pururun (Jonatan Rhodin) wrote…
This should be changed to
enableSplitTunneling
or something similar.
Done.
Co-Authored-By: Boban Sijuk <[email protected]>
Co-Authored-By: Boban Sijuk <[email protected]>
364c147
to
a5aa6fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
Opened a new PR with the same commits here, just adjusted for compose navigation: #5641 |
This change is