Test for expected app state if settings can not be parsed #5565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlon
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)
mullvad-daemon/src/settings/mod.rs line 518 at r1 (raw file):
.await; assert!(
Should we assert that block_when_disconnected == false here?
MarkusPettersson98
force-pushed
the
do-not-leak-traffic-if-settings-can-not-be-parsed-during-app-des-463
branch
2 times, most recently
from
79ee159 to
156ca8f
Compare
dlon
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Reviewed 6 of 6 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Separate concerns of `SettingsPersister`'s error recovery and the deserialization of `Settings` from file.
MarkusPettersson98
force-pushed
the
do-not-leak-traffic-if-settings-can-not-be-parsed-during-app-des-463
branch
from
156ca8f to
37bf990
Compare
MarkusPettersson98
deleted the
do-not-leak-traffic-if-settings-can-not-be-parsed-during-app-des-463
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify that the app enables "Always require VPN" by default if the settings cannot be parsed.
These changes/additions aims to guard against regressions to this behavior. This behavior was introduced in the 2022.1 desktop release: https://github.com/mullvad/mullvadvpn-app/blob/main/CHANGELOG.md#security-7
This change is