move-transportstrategy-into-mullvadtransport-ios-287 #5573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mojganii
changed the title
rablador
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
How come issue IOS-28 Ability to delete an account is included in this PR?
Reviewed 87 of 87 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
rablador
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Aha, probably a typo in the branch, linking it in automatically from Linear.
Reviewable status:
mojganii
force-pushed
the
move-transportstrategy-into-mullvadtransport-ios-28
branch
from
6ba625c to
d51d031
Compare
buggmagnet
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Reviewed 87 of 87 files at r1, all commit messages.
Reviewable status:
buggmagnet
force-pushed
the
move-transportstrategy-into-mullvadtransport-ios-28
branch
from
d51d031 to
9057933
Compare
buggmagnet
deleted the
move-transportstrategy-into-mullvadtransport-ios-28
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr merges
MullvadTransport,RelayCacheandRelaySelectorintoMullvadREST. by merging these components, the codebase achieves a higher level of common functionalities, enhancing overall code organization and maintainability.This change is