Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing private IP range 198.18.0.0/15 #5576

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ Line wrap the file at 100 chars. Th
## [Unreleased]
### Added
- Add CLI support for applying patches to the settings with `mullvad import-settings`.
- Add `198.18.0.0/15` to local network sharing ranges.

### Changed
#### Android
Expand Down
1 change: 1 addition & 0 deletions docs/security.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ The following network traffic is allowed or blocked independent of state:
* `10.0.0.0/8`
* `172.16.0.0/12`
* `192.168.0.0/16`
* `198.18.0.0/15`
* `169.254.0.0/16` (Link-local IPv4 range)
* `fe80::/10` (Link-local IPv6 range)
* `fc00::/7` (Unique local address (ULA) range)
Expand Down
3 changes: 2 additions & 1 deletion talpid-core/src/firewall/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,13 @@ mod imp;
pub use self::imp::Error;

/// When "allow local network" is enabled the app will allow traffic to and from these networks.
pub(crate) static ALLOWED_LAN_NETS: Lazy<[IpNetwork; 6]> = Lazy::new(|| {
pub(crate) static ALLOWED_LAN_NETS: Lazy<[IpNetwork; 7]> = Lazy::new(|| {
[
IpNetwork::V4(Ipv4Network::new(Ipv4Addr::new(10, 0, 0, 0), 8).unwrap()),
IpNetwork::V4(Ipv4Network::new(Ipv4Addr::new(172, 16, 0, 0), 12).unwrap()),
IpNetwork::V4(Ipv4Network::new(Ipv4Addr::new(192, 168, 0, 0), 16).unwrap()),
IpNetwork::V4(Ipv4Network::new(Ipv4Addr::new(169, 254, 0, 0), 16).unwrap()),
IpNetwork::V4(Ipv4Network::new(Ipv4Addr::new(198, 18, 0, 0), 15).unwrap()),
IpNetwork::V6(Ipv6Network::new(Ipv6Addr::new(0xfe80, 0, 0, 0, 0, 0, 0, 0), 10).unwrap()),
IpNetwork::V6(Ipv6Network::new(Ipv6Addr::new(0xfc00, 0, 0, 0, 0, 0, 0, 0), 7).unwrap()),
]
Expand Down
1 change: 1 addition & 0 deletions windows/winfw/src/winfw/winfw.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ wfp::IpNetwork g_privateIpRanges[] = {
wfp::IpNetwork(wfp::IpAddress::Literal{172, 16, 0, 0}, 12),
wfp::IpNetwork(wfp::IpAddress::Literal{192, 168, 0, 0}, 16),
wfp::IpNetwork(wfp::IpAddress::Literal{169, 254, 0, 0}, 16),
wfp::IpNetwork(wfp::IpAddress::Literal{198, 18, 0, 0}, 15),
wfp::IpNetwork(wfp::IpAddress::Literal6{0, 0, 0, 0, 0, 0, 0, 1}, 128),
wfp::IpNetwork(wfp::IpAddress::Literal6{0xfe80, 0, 0, 0, 0, 0, 0, 0}, 10),
wfp::IpNetwork(wfp::IpAddress::Literal6{0xfc80, 0, 0, 0, 0, 0, 0, 0}, 7)
Expand Down