Fix local proxy not working if started before connecting #5647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jontified
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
dlon
force-pushed
the
macos-fix-local-proxy
branch
2 times, most recently
from
00e3261 to
d6e1328
Compare
dlon
force-pushed
the
macos-fix-local-proxy
branch
from
d6e1328 to
89dbd59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only the first SYN packet was allowed in the firewall. If the connection to the custom proxy server was initiated before connecting to the VPN, this packet was never seen, so PF blocked the connection.
Note: This prevents PF from blocking connections to the first hop that were initiated before the rules were added.
Introduced in #5587
This change is