-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove version
and publish
from cargo metadata
#5660
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 35 files reviewed, 1 unresolved discussion
.github/workflows/rust-supply-chain.yml
line 23 at r1 (raw file):
with: log-level: warn rust-version: stable
This was needed since it by default used some older version of Rust/cargo. Luckily it accepted "stable" and did not need a specific version.
1682ed2
to
7d10a53
Compare
version
and publish
from cargo metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 36 files reviewed, 1 unresolved discussion
.github/workflows/rust-unused-dependencies.yml
line 13 at r2 (raw file):
env: # Pinning nightly just to avoid random breakage. It's fine to bump this at any time RUST_NIGHTLY_TOOLCHAIN: nightly-2024-01-07
Another place that needed bumping to a version of cargo that was fine with no version
field.
7d10a53
to
9f5f344
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 36 files reviewed, 1 unresolved discussion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 36 files reviewed, all discussions resolved
.github/workflows/rust-supply-chain.yml
line 23 at r1 (raw file):
Previously, faern (Linus Färnstrand) wrote…
This was needed since it by default used some older version of Rust/cargo. Luckily it accepted "stable" and did not need a specific version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 35 of 35 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
Since Rust 1.75.0 the `version` field is optional. The version defaults to "0.0.0" if it's not specified, and `publish` defaults to false if no version has been given. So by not specifying a version we get both `version = "0.0.0" and `publish = false` "for free"
9f5f344
to
d884332
Compare
Since Rust 1.75.0 the
version
field is optional. The version defaults to "0.0.0" if it's not specified, andpublish
defaults to false if no version has been given. So by not specifying a version we get bothversion = "0.0.0"
andpublish = false
"for free". This means we can get away with a bit less metadata boilerplate ✨This change is