-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test logging out #5878
Test logging out #5878
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 27 files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 27 of 27 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @niklasberglund)
ios/MullvadVPN/View controllers/Alert/AlertViewController.swift
line 113 at r1 (raw file):
view.backgroundColor = .black.withAlphaComponent(0.5) let accessibilityIdentifier = presentation.accessibilityIdentifier ?? .alertContainerView
Nit: Set id to view.accessibilityIdentifier
directly instead. No need for extra verbosity.
ios/MullvadVPN.xcodeproj/project.pbxproj
line 3110 at r1 (raw file):
58CE5E61224146200008646E /* Products */, 584F991F2902CBDD001F858D /* Frameworks */, 85EC620B2B838B3A005AFFB5 /* Recovered References */,
Remove
ios/MullvadVPN.xcodeproj/project.pbxproj
line 3565 at r1 (raw file):
sourceTree = "<group>"; }; 85EC620B2B838B3A005AFFB5 /* Recovered References */ = {
Remove
ios/MullvadVPN.xcodeproj/project.pbxproj
line 4256 at r1 (raw file):
); name = MullvadVPNUITests; packageProductDependencies = (
Remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 27 of 27 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @niklasberglund)
aa7dd42
to
e94b9c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 28 files reviewed, 4 unresolved discussions (waiting on @buggmagnet and @rablador)
ios/MullvadVPN.xcodeproj/project.pbxproj
line 3110 at r1 (raw file):
Previously, rablador (Jon Petersson) wrote…
Remove
Removed
ios/MullvadVPN.xcodeproj/project.pbxproj
line 3565 at r1 (raw file):
Previously, rablador (Jon Petersson) wrote…
Remove
Removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 28 files reviewed, 4 unresolved discussions (waiting on @buggmagnet and @rablador)
ios/MullvadVPN/View controllers/Alert/AlertViewController.swift
line 113 at r1 (raw file):
Previously, rablador (Jon Petersson) wrote…
Nit: Set id to
view.accessibilityIdentifier
directly instead. No need for extra verbosity.
Setting it directly now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 28 files reviewed, 4 unresolved discussions (waiting on @buggmagnet and @rablador)
ios/MullvadVPN.xcodeproj/project.pbxproj
line 4256 at r1 (raw file):
Previously, rablador (Jon Petersson) wrote…
Remove?
We talked IRL about this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 27 of 27 files at r2, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @niklasberglund and @rablador)
ios/MullvadVPN.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
line 0 at r2 (raw file):
git checkout main -- MullvadVPN.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/
e94b9c8
to
539fdc1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @buggmagnet and @rablador)
ios/MullvadVPN.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
line at r2 (raw file):
Previously, buggmagnet wrote…
git checkout main -- MullvadVPN.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/
Restored
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @rablador)
539fdc1
to
a8603cd
Compare
Note that this PR builds upon changes from #5855 so not ready for review until it has been merged and marked as draft for now.
Introduced log out test which validates that device is created when logging in and removed when logging out. Note that the implementation slightly differs from the issue description in Linear because the issue mentions reading the device name but the implementation don't. I think it wouldn't serve any purpose since the test makes sure that one device is created and then removed?
To test the changes run
testLogOut
underAccountTests
.This change is