Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test logging out #5878

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Test logging out #5878

merged 1 commit into from
Mar 14, 2024

Conversation

niklasberglund
Copy link
Contributor

@niklasberglund niklasberglund commented Feb 28, 2024

Note that this PR builds upon changes from #5855 so not ready for review until it has been merged and marked as draft for now.

Introduced log out test which validates that device is created when logging in and removed when logging out. Note that the implementation slightly differs from the issue description in Linear because the issue mentions reading the device name but the implementation don't. I think it wouldn't serve any purpose since the test makes sure that one device is created and then removed?

To test the changes run testLogOut under AccountTests.


This change is Reviewable

@niklasberglund niklasberglund added the iOS Issues related to iOS label Feb 28, 2024
Copy link

linear bot commented Feb 28, 2024

IOS-436 Test logging out

Copy link
Collaborator

@mojganii mojganii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 27 files reviewed, all discussions resolved

@niklasberglund niklasberglund requested a review from rablador March 8, 2024 09:36
Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 27 of 27 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @niklasberglund)


ios/MullvadVPN/View controllers/Alert/AlertViewController.swift line 113 at r1 (raw file):

        view.backgroundColor = .black.withAlphaComponent(0.5)

        let accessibilityIdentifier = presentation.accessibilityIdentifier ?? .alertContainerView

Nit: Set id to view.accessibilityIdentifier directly instead. No need for extra verbosity.


ios/MullvadVPN.xcodeproj/project.pbxproj line 3110 at r1 (raw file):

				58CE5E61224146200008646E /* Products */,
				584F991F2902CBDD001F858D /* Frameworks */,
				85EC620B2B838B3A005AFFB5 /* Recovered References */,

Remove


ios/MullvadVPN.xcodeproj/project.pbxproj line 3565 at r1 (raw file):

			sourceTree = "<group>";
		};
		85EC620B2B838B3A005AFFB5 /* Recovered References */ = {

Remove


ios/MullvadVPN.xcodeproj/project.pbxproj line 4256 at r1 (raw file):

			);
			name = MullvadVPNUITests;
			packageProductDependencies = (

Remove?

Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 27 of 27 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @niklasberglund)

@niklasberglund niklasberglund force-pushed the test-logging-out-ios-436 branch 2 times, most recently from aa7dd42 to e94b9c8 Compare March 12, 2024 12:53
Copy link
Contributor Author

@niklasberglund niklasberglund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 28 files reviewed, 4 unresolved discussions (waiting on @buggmagnet and @rablador)


ios/MullvadVPN.xcodeproj/project.pbxproj line 3110 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

Remove

Removed


ios/MullvadVPN.xcodeproj/project.pbxproj line 3565 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

Remove

Removed

Copy link
Contributor Author

@niklasberglund niklasberglund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 28 files reviewed, 4 unresolved discussions (waiting on @buggmagnet and @rablador)


ios/MullvadVPN/View controllers/Alert/AlertViewController.swift line 113 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

Nit: Set id to view.accessibilityIdentifier directly instead. No need for extra verbosity.

Setting it directly now

Copy link
Contributor Author

@niklasberglund niklasberglund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 28 files reviewed, 4 unresolved discussions (waiting on @buggmagnet and @rablador)


ios/MullvadVPN.xcodeproj/project.pbxproj line 4256 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

Remove?

We talked IRL about this

Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 27 of 27 files at r2, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @niklasberglund and @rablador)


ios/MullvadVPN.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved line 0 at r2 (raw file):
git checkout main -- MullvadVPN.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/

@niklasberglund niklasberglund force-pushed the test-logging-out-ios-436 branch from e94b9c8 to 539fdc1 Compare March 13, 2024 08:54
Copy link
Contributor Author

@niklasberglund niklasberglund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @buggmagnet and @rablador)


ios/MullvadVPN.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved line at r2 (raw file):

Previously, buggmagnet wrote…

git checkout main -- MullvadVPN.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/

Restored

Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @rablador)

@buggmagnet buggmagnet force-pushed the test-logging-out-ios-436 branch from 539fdc1 to a8603cd Compare March 14, 2024 07:30
@buggmagnet buggmagnet merged commit 187f52f into main Mar 14, 2024
5 of 6 checks passed
@buggmagnet buggmagnet deleted the test-logging-out-ios-436 branch March 14, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants