Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated iOS end to end tests workflow condition #5888

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

niklasberglund
Copy link
Contributor

@niklasberglund niklasberglund commented Mar 1, 2024

Updated iOS end to end tests workflow to only be triggered on merge to main when any file under ios or the workflow file itself has changed.

Have verified it to be working as expected by creating a PR in my fork changing README.md in root directory which didn't trigger the workflow and created a PR changing AccountTests.swift under ios directory which did trigger the workflow to run.


This change is Reviewable

@niklasberglund niklasberglund added the iOS Issues related to iOS label Mar 1, 2024
Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@buggmagnet buggmagnet merged commit 624d37a into main Mar 1, 2024
@buggmagnet buggmagnet deleted the run-ios-tests-conditional branch March 1, 2024 15:46
@buggmagnet buggmagnet force-pushed the run-ios-tests-conditional branch from afc9bc1 to e36fc6d Compare March 1, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants