-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix long method #5898
Fix long method #5898
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Rawa)
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/ConnectScreen.kt
line 111 at r1 (raw file):
val connectViewModel: ConnectViewModel = koinViewModel() val state by connectViewModel.uiState.collectAsStateWithLifecycle()
I guess this will not be considered a change when we merge that other PR?
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/ConnectScreen.kt
line 165 at r1 (raw file):
@Composable private fun ConnectScreen(
This would break tests no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Pururun)
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/ConnectScreen.kt
line 111 at r1 (raw file):
Previously, Pururun (Jonatan Rhodin) wrote…
I guess this will not be considered a change when we merge that other PR?
Correct.
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/ConnectScreen.kt
line 165 at r1 (raw file):
Previously, Pururun (Jonatan Rhodin) wrote…
This would break tests no?
Ah yes, correct. I'll fix it.
50804ee
to
83c3e79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
9f3a76e
to
7eb767a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 6 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
060ed9c
to
8286da7
Compare
8286da7
to
082df9d
Compare
This PR splits a bunch of long methods that result in detekt linting issues.
This change is