Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix long method #5898

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Fix long method #5898

merged 1 commit into from
Mar 8, 2024

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Mar 5, 2024

This PR splits a bunch of long methods that result in detekt linting issues.


This change is Reviewable

@Rawa Rawa requested review from albin-mullvad and Pururun and removed request for albin-mullvad March 5, 2024 09:18
@Rawa Rawa self-assigned this Mar 5, 2024
@Rawa Rawa added the Android Issues related to Android label Mar 5, 2024
@Rawa Rawa requested a review from albin-mullvad March 5, 2024 09:18
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Rawa)


android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/ConnectScreen.kt line 111 at r1 (raw file):

    val connectViewModel: ConnectViewModel = koinViewModel()

    val state by connectViewModel.uiState.collectAsStateWithLifecycle()

I guess this will not be considered a change when we merge that other PR?


android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/ConnectScreen.kt line 165 at r1 (raw file):

@Composable
private fun ConnectScreen(

This would break tests no?

Copy link
Contributor Author

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Pururun)


android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/ConnectScreen.kt line 111 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

I guess this will not be considered a change when we merge that other PR?

Correct.


android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/ConnectScreen.kt line 165 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

This would break tests no?

Ah yes, correct. I'll fix it.

@Rawa Rawa force-pushed the fix-long-method-detekt-lint branch from 50804ee to 83c3e79 Compare March 5, 2024 10:11
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Rawa Rawa force-pushed the fix-long-method-detekt-lint branch 3 times, most recently from 9f3a76e to 7eb767a Compare March 5, 2024 13:30
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 6 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Rawa Rawa force-pushed the fix-long-method-detekt-lint branch 3 times, most recently from 060ed9c to 8286da7 Compare March 8, 2024 09:11
@Rawa Rawa force-pushed the fix-long-method-detekt-lint branch from 8286da7 to 082df9d Compare March 8, 2024 09:16
@Rawa Rawa merged commit c125450 into main Mar 8, 2024
24 of 25 checks passed
@Rawa Rawa deleted the fix-long-method-detekt-lint branch March 8, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants