Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase ripple contrast #5911

Merged

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Mar 7, 2024

Fixes: DROID-720


This change is Reviewable

Copy link

linear bot commented Mar 7, 2024

@Rawa Rawa requested a review from Pururun March 7, 2024 08:39
@Rawa Rawa self-assigned this Mar 7, 2024
@Rawa Rawa added the Android Issues related to Android label Mar 7, 2024
@Rawa Rawa force-pushed the investigate-improving-contrast-of-focus-highlight-droid-649 branch from c805f4f to 25b34c0 Compare March 7, 2024 13:03
@Rawa Rawa marked this pull request as draft March 8, 2024 09:08
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Looks much more clear when using DPAD/focus navigation, so I suggest we go ahead with this improvement!

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link

linear bot commented Mar 11, 2024

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rawa please update the changelog as well

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Rawa Rawa force-pushed the investigate-improving-contrast-of-focus-highlight-droid-649 branch from 25b34c0 to 83ebef7 Compare March 11, 2024 15:43
Copy link
Contributor Author

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albin-mullvad Updated! 👍

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @albin-mullvad)

@Rawa Rawa force-pushed the investigate-improving-contrast-of-focus-highlight-droid-649 branch from 0b7486b to e628186 Compare March 11, 2024 15:48
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)


CHANGELOG.md line 43 at r3 (raw file):

#### Android
- Migrate to Compose Navigation which also improves screen transition animations.
- Increase focus highlight opacity

nit: end with a dot

@Rawa Rawa marked this pull request as ready for review March 12, 2024 06:43
@Rawa Rawa merged commit 1c6d12f into main Mar 12, 2024
25 of 26 checks passed
@Rawa Rawa deleted the investigate-improving-contrast-of-focus-highlight-droid-649 branch March 12, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants