Introduce ObservedState.negotiatingKey and TunnelState.negotiatingKey… #5919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buggmagnet
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
rablador
reviewed
Mar 11, 2024
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @acb-mv)
ios/MullvadVPN/TunnelManager/StopTunnelOperation.swift line 46 at r1 (raw file):
#endif case .disconnected, .disconnecting, .pendingReconnect, .waitingForConnectivity(.noNetwork):
This makes so much more sense!
rablador
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Reviewable status:
…, behind DEBUG flag
buggmagnet
force-pushed
the
introduce-a-state-that-means-we-are-exchanging-keys-in-ios-530
branch
from
5f17f5a to
8ab109d
Compare
buggmagnet
deleted the
introduce-a-state-that-means-we-are-exchanging-keys-in-ios-530
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…, behind DEBUG flag
This will allow the key negotiation to be put in the state-machine flow of the PacketTunnelProvider/Actor, giving some leeway with the tunnel setup watchdog timer. It is a step in a work in progress, and not used yet.
This change is