Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filter screen selection #5920

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Mar 7, 2024

This PR fixes a regression where entering the filter screen did not select all provider by default when Constraint was Any


This change is Reviewable

@Rawa Rawa requested a review from Pururun March 7, 2024 15:27
Copy link

linear bot commented Mar 7, 2024

@Rawa Rawa requested a review from albin-mullvad March 7, 2024 15:27
@Rawa Rawa self-assigned this Mar 7, 2024
@Rawa Rawa added the Android Issues related to Android label Mar 7, 2024
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Rawa Rawa merged commit 972d2fa into main Mar 8, 2024
25 checks passed
@Rawa Rawa deleted the all-providers-are-not-selected-by-default-in-filterscreen-droid-730 branch March 8, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants