Add the PrivacyInfo manifest to both target bundles #5959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mojganii
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
buggmagnet
force-pushed
the
copy-the-privacyinfoxcprivacy-file-into-the-final-bundle-to-ios-555
branch
from
136f070 to
57bc0fd
Compare
buggmagnet
deleted the
copy-the-privacyinfoxcprivacy-file-into-the-final-bundle-to-ios-555
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we added the privacy manifest to our project, it seems we forgot to include it in the bundle, which triggered Apple's automatic emails letting us know we are missing it.
This PR fixes that. The
PrivacyInfo.xcprivacyis now added both to the main target, and the network extension bundle.This change is