Add test for audit ticket MUL-02-002

[MarkusPettersson98]

This PR adds an integration test to check for regressions to audit ticket MUL-02-002 - Firewall allows deanonymization by eavesdropper. The fix for this issue has been included in the app since version 2020.5.

---

This change is 

[linear]

DES-419 ServerIP/MUL-02-002 WP2 (2020 app audit)

[hulthe]

Very readable test. Nice.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @MarkusPettersson98)

---

test/test-manager/src/tests/tunnel.rs line 828 at r1 (raw file):

) -> Result<(), anyhow::Error> {
    // Step 0 - Disconnect from any active tunnel connection
    helpers::disconnect_and_wait(&mut mullvad_client).await?;

IIRC the runtime makes sure we're disconnected when we start a test

---

test/test-manager/src/tests/tunnel.rs line 853 at r1 (raw file):

    // identifiable payload
    // FIXME: This needs to be kept in sync with the magic payload string defined in `connection_cheker::net`.
    // An easy fix would be to make the payload for `ConnCheck` configurable.

---

test/test-manager/src/tests/tunnel.rs line 869 at r1 (raw file):

    // Before proceeding, assert that the method of detecting identifiable packets work.
    conn_artist.check_connection().await?;
    let monitor_result = rogue_packet_monitor.into_result().await.unwrap();

unwrap?

[dlon]

Reviewed all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @hulthe and @MarkusPettersson98)

---

test/test-manager/src/tests/tunnel.rs line 828 at r1 (raw file):

Previously, hulthe (Joakim Hulthe) wrote…

IIRC the runtime makes sure we're disconnected when we start a test

+1

---

test/test-manager/src/tests/tunnel.rs line 848 at r1 (raw file):

    };
    helpers::disconnect_and_wait(&mut mullvad_client).await?;
    let gateway = endpoint.endpoint.address;

gateway seems wrong. Also, it's not guaranteed to select the same endpoint when reconnecting (step 4).

---

test/test-manager/src/tests/tunnel.rs line 853 at r1 (raw file):

Previously, hulthe (Joakim Hulthe) wrote…

+1. Or just define it as a constant somewhere.

[MarkusPettersson98]

Reviewable status: 2 of 9 files reviewed, 4 unresolved discussions (waiting on @dlon and @hulthe)

---

test/test-manager/src/tests/tunnel.rs line 828 at r1 (raw file):

Previously, dlon (David Lönnhager) wrote…

+1

Done.

---

test/test-manager/src/tests/tunnel.rs line 848 at r1 (raw file):

Previously, dlon (David Lönnhager) wrote…

gateway seems wrong. Also, it's not guaranteed to select the same endpoint when reconnecting (step 4).

Done

---

test/test-manager/src/tests/tunnel.rs line 853 at r1 (raw file):

Previously, dlon (David Lönnhager) wrote…

+1. Or just define it as a constant somewhere.

Done

---

test/test-manager/src/tests/tunnel.rs line 869 at r1 (raw file):

Previously, hulthe (Joakim Hulthe) wrote…

unwrap?

🙀
Fixed! 🧽

[hulthe]

Reviewed 7 of 7 files at r2, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @dlon and @MarkusPettersson98)

---

test/connection-checker/src/cli.rs line 39 at r2 (raw file):

    /// Junk data for each UDP and TCP packet
    #[clap(long, requires = "leak")]
    pub payload: Option<String>,

Nit: I would use #[clap(default_value = "Hello there!")] instead of making this an option

[MarkusPettersson98]

Reviewable status: 7 of 9 files reviewed, 4 unresolved discussions (waiting on @dlon and @hulthe)

---

test/connection-checker/src/cli.rs line 39 at r2 (raw file):

Previously, hulthe (Joakim Hulthe) wrote…

Nit: I would use #[clap(default_value = "Hello there!")] instead of making this an option

Ah, that's better!

[hulthe]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @dlon)

[hulthe]

Reviewed 4 of 4 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dlon)

[hulthe]

Reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dlon)

[dlon]

Reviewed 1 of 4 files at r4, 1 of 2 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved