Do not show a toast after dismissing the dns dialog

[Pururun]

---

This change is 

[linear]

DROID-743 "DNS settings might not go into effect immediately"-snackbar should not show when no new setting has been set.

[Rawa]

Logic does unfortunately not work coherently.

E.g

• Add the 1.1.1.1 (see the toast)
• Toggle off ( = will show toast)
• Toggle on ( = will show toast)
• Remove 1.1.1.1, will toggle off but not show toast

What if we instead use the NavResult of dns dialog, and we can use value to indicate that the value has changed. If it has changed we can show the snackbar.

Reviewable status: 0 of 1 files reviewed, all discussions resolved

[Pururun]

Fixed

Reviewable status: 0 of 4 files reviewed, all discussions resolved

[Rawa]

Reviewed 3 of 4 files at r2, all commit messages.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @Pururun)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/viewmodel/VpnSettingsViewModel.kt line 131 at r2 (raw file):

        if (enable && vmState.value.customDnsList.isEmpty()) {
            viewModelScope.launch { _uiSideEffect.send(VpnSettingsSideEffect.NavigateToDnsDialog) }
        } else if (showToast) {

Shouldn't this suffice? I don't think showToast parameter is needed.

        } else if (vmState.value.customDnsList.isNotEmpty()) {
            showApplySettingChangesWarningToast()
        }

[Pururun]

Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @Rawa)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/viewmodel/VpnSettingsViewModel.kt line 131 at r2 (raw file):

Previously, Rawa (David Göransson) wrote…

Shouldn't this suffice? I don't think showToast parameter is needed.

        } else if (vmState.value.customDnsList.isNotEmpty()) {
            showApplySettingChangesWarningToast()
        }

Done

[Rawa]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved