Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Reset to default" inconsistency #5994

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Mar 20, 2024

  • Hides "Reset to default" when already at default
  • Makes "Reset to default" button red

This change is Reviewable

Copy link

linear bot commented Mar 20, 2024

@albin-mullvad albin-mullvad added the Android Issues related to Android label Mar 20, 2024
@Rawa Rawa force-pushed the reset-to-default-inconsistency-droid-764 branch from 242363d to fd538f0 Compare March 20, 2024 15:18
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Rawa Rawa force-pushed the reset-to-default-inconsistency-droid-764 branch from fd538f0 to 1738bd1 Compare March 21, 2024 08:50
@Rawa Rawa merged commit e53360f into main Mar 21, 2024
26 checks passed
@Rawa Rawa deleted the reset-to-default-inconsistency-droid-764 branch March 21, 2024 08:58
@Rawa Rawa self-assigned this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants