Add relay ip override e2e tests

[hulthe]

---

This change is 

[linear]

DES-579 Write relay selection tests for relay IP overrides

[MarkusPettersson98]

Reviewed 2 of 3 files at r1, 5 of 5 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[MarkusPettersson98]

Reviewed 1 of 1 files at r5, 1 of 1 files at r6, 1 of 1 files at r7, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @hulthe)

---

test/test-manager/src/tests/relay_ip_overrides.rs line 352 at r6 (raw file):

/// Returns a handle that will stop the proxy when dropped.
async fn spawn_tcp_proxy(destination: SocketAddr, port: u16) -> anyhow::Result<AbortOnDrop<()>> {
    let socket = TcpListener::bind((Ipv4Addr::UNSPECIFIED, port)).await?;

On further inspection, I don't think that we should bind to all local interfaces - just the temporary bridge interface created for running the tests.

On Linux, there is this constant network called test_manager::vm::network::linux::TEST_SUBNET which could be used to only bind to the bridge interface on the host. The caveat is that this constant is not available on macOS, but a hacky way to define it would be to let it equal NON_TUN_GATEWAY.

Anyway, I suggest changing Ipv4Addr::UNSPECIFIED to TEST_SUBNET:

let socket = TcpListener::bind((TEST_SUBNET.ip(), port)).await?;

This comment is true for the UDP-socket created in spawn_udp_proxy as well 😊

Code quote:

let socket = TcpListener::bind((Ipv4Addr::UNSPECIFIED, port)).await?;

[hulthe]

Reviewable status: 6 of 7 files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)

---

test/test-manager/src/tests/relay_ip_overrides.rs line 352 at r6 (raw file):

Previously, MarkusPettersson98 (Markus Pettersson) wrote…

On further inspection, I don't think that we should bind to all local interfaces - just the temporary bridge interface created for running the tests.

On Linux, there is this constant network called test_manager::vm::network::linux::TEST_SUBNET which could be used to only bind to the bridge interface on the host. The caveat is that this constant is not available on macOS, but a hacky way to define it would be to let it equal NON_TUN_GATEWAY.

Anyway, I suggest changing Ipv4Addr::UNSPECIFIED to TEST_SUBNET:

let socket = TcpListener::bind((TEST_SUBNET.ip(), port)).await?;

This comment is true for the UDP-socket created in spawn_udp_proxy as well 😊

Done.

[MarkusPettersson98]

Reviewed 1 of 1 files at r8, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

---

test/test-manager/src/tests/relay_ip_overrides.rs line 352 at r6 (raw file):

Previously, hulthe (Joakim Hulthe) wrote…

Done.

Nice! 🔥

[MarkusPettersson98]

Reviewed 2 of 2 files at r9, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved