Prevent disconnected from daemon notification on suspend #6048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkusPettersson98
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
raksooo
force-pushed
the
disconnected-from-daemon-notification-on-suspend-des-723
branch
from
7a8051b to
f1fa32d
Compare
raksooo
deleted the
disconnected-from-daemon-notification-on-suspend-des-723
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Electron app intentionally disconnectes from the daemon on suspend the disconnected from daemon-notification shouldn't be disaplayed. This PR fixes that by informing the disconnect-listener that the disconnect was planned.
This change is