Fix floating effect for custom list description #6061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albin-mullvad
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Rawa
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
Rawa
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Reviewable status:
Pururun
force-pushed
the
add-background-to-custom-lists-description-text-in-select-droid-827
branch
4 times, most recently
from
c8f448b to
5cc6c98
Compare
albin-mullvad
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
Pururun
force-pushed
the
add-background-to-custom-lists-description-text-in-select-droid-827
branch
from
5cc6c98 to
1f42ab9
Compare
Rawa
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
Pururun
force-pushed
the
add-background-to-custom-lists-description-text-in-select-droid-827
branch
from
1f42ab9 to
769b619
Compare
Pururun
force-pushed
the
add-background-to-custom-lists-description-text-in-select-droid-827
branch
from
769b619 to
b7ad5b6
Compare
Pururun
deleted the
add-background-to-custom-lists-description-text-in-select-droid-827
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the effect of custom list description text "floating" above other items during the expand/collapse animation for custom lists in the select location screen.
This change is