Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show loading states in purchasing flow an extra minimum amount of time #6084

Conversation

Pururun
Copy link
Contributor

@Pururun Pururun commented Apr 8, 2024

This is to reduce the flickering in the ui.


This change is Reviewable

Copy link

linear bot commented Apr 8, 2024

@Pururun Pururun self-assigned this Apr 8, 2024
@Pururun Pururun added the Android Issues related to Android label Apr 8, 2024
@Pururun Pururun requested a review from Rawa April 8, 2024 09:45
@Pururun Pururun force-pushed the show-loading-payment-dialog-for-a-minimum-amount-of-time-droid-599 branch from 4ac19d8 to 15cb8a3 Compare April 10, 2024 08:27
@Pururun Pururun changed the title Show loading states in purchasing flow a minimum amount of time Show loading states in purchasing flow an extra minimum amount of time Apr 10, 2024
@Pururun
Copy link
Contributor Author

Pururun commented Apr 10, 2024

@Rawa Updated the PR to be more like we discussed yesterday.

@albin-mullvad
Copy link
Collaborator

@Rawa please review!

Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun force-pushed the show-loading-payment-dialog-for-a-minimum-amount-of-time-droid-599 branch 4 times, most recently from a80bfe8 to 789b4ed Compare April 16, 2024 19:24
@Pururun Pururun force-pushed the show-loading-payment-dialog-for-a-minimum-amount-of-time-droid-599 branch from 789b4ed to 85ba264 Compare April 16, 2024 21:14
@Pururun Pururun merged commit 446baab into main Apr 16, 2024
22 checks passed
@Pururun Pururun deleted the show-loading-payment-dialog-for-a-minimum-amount-of-time-droid-599 branch April 16, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants