Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where offline servers can be selected #6085

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

rablador
Copy link
Contributor

@rablador rablador commented Apr 8, 2024

This PR takes care of two issues:

  • Inactive locations should not be selectable.
  • Parent nodes (ie country/city) should not be marked inactive if at least one child is active.

This change is Reviewable

@rablador rablador added bug iOS Issues related to iOS labels Apr 8, 2024
@rablador rablador requested review from buggmagnet and mojganii April 8, 2024 11:58
Copy link

linear bot commented Apr 8, 2024

Copy link
Collaborator

@mojganii mojganii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 2 files reviewed, all discussions resolved

@rablador rablador force-pushed the offline-server-appears-online-ios-593 branch from adedc97 to 1d69764 Compare April 9, 2024 07:21
Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@buggmagnet buggmagnet force-pushed the offline-server-appears-online-ios-593 branch from 1d69764 to e0bdd96 Compare April 9, 2024 14:43
@buggmagnet buggmagnet merged commit 12869ab into main Apr 9, 2024
6 of 7 checks passed
@buggmagnet buggmagnet deleted the offline-server-appears-online-ios-593 branch April 9, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants