Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OS version RPC to test framework #6087

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Add OS version RPC to test framework #6087

merged 3 commits into from
Apr 9, 2024

Conversation

dlon
Copy link
Member

@dlon dlon commented Apr 8, 2024

This can be expanded as needed. Currently, we only need to obtain the major version on macOS.


This change is Reviewable

@dlon dlon requested a review from MarkusPettersson98 April 8, 2024 14:54
@dlon dlon marked this pull request as ready for review April 8, 2024 15:40
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dlon dlon merged commit 77d24c0 into main Apr 9, 2024
55 of 60 checks passed
@dlon dlon deleted the test-add-os-version-info branch April 9, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants