Add delete custom list entry bottom sheet #6157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albin-mullvad
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Rawa
force-pushed
the
add-ability-to-delete-entry-from-custom-list-in-select-droid-910
branch
from
5958e7e to
ca1d45e
Compare
Rawa
deleted the
add-ability-to-delete-entry-from-custom-list-in-select-droid-910
branch
Pururun
reviewed
Apr 19, 2024
There was a problem hiding this comment.
Reviewed 1 of 6 files at r1.
Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on @albin-mullvad and @Rawa)
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/cell/RelayLocationCell.kt line 139 at r1 (raw file):
selectedItem: RelayItem? = null, onSelectRelay: (item: RelayItem) -> Unit = {}, onLongClick: (item: RelayItem) -> Unit = {},
Probably should not be in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a custom list sheet for the direct children of the custom list.
This change is