Only show blue top bar in the welcome screen #6159
Conversation
Pururun
force-pushed
the
top-bar-color-on-welcome-screen-droid-837
branch
from
3fc75be to
3d0cd61
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)
a discussion (no related file):
Lots of commas added in this PR. Were those added intentionally?
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)
a discussion (no related file):
Previously, albin-mullvad wrote…
Lots of commas added in this PR. Were those added intentionally?
I think ktfmt might not be configured properly.
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)
a discussion (no related file):
Previously, Pururun (Jonatan Rhodin) wrote…
I think
ktfmtmight not be configured properly.
Did you follow our documention or is it outdated?
https://github.com/mullvad/mullvadvpn-app/blob/main/android/README.md#kotlin-formatting
Pururun
force-pushed
the
top-bar-color-on-welcome-screen-droid-837
branch
from
3d0cd61 to
a15d373
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)
a discussion (no related file):
Previously, albin-mullvad wrote…
Did you follow our documention or is it outdated?
https://github.com/mullvad/mullvadvpn-app/blob/main/android/README.md#kotlin-formatting
I thought I had installed the plugin, but I had not, so it was just user error this time.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Before we showed the tunnel state colors, according to the design we should only show the blue colors.
This change is