Add a new container view to wrap the whole location selection

[rablador]

The wrapper should have a segmented control. The child will be updated through the wrapper, keeping most of the previous implementation intact.

---

This change is 

[linear]

IOS-630 Add a new container view to wrap the whole location selection

[buggmagnet]

Reviewed 3 of 7 files at r1, all commit messages.
Reviewable status: 3 of 7 files reviewed, 2 unresolved discussions (waiting on @rablador)

---

ios/MullvadVPN/View controllers/SelectLocation/LocationViewControllerWrapper.swift line 66 at r1 (raw file):

        navigationItem.largeTitleDisplayMode = .never

        navigationItem.title = NSLocalizedString(

We will probably want to have accessibility on those items if we don't want to break already existing UI Tests here.
Please Make sure you run the Custom Lists UI tests when you rebase from main.

---

ios/MullvadVPN/View controllers/SelectLocation/LocationViewControllerWrapper.swift line 102 at r1 (raw file):

        segmentedControl.insertSegment(withTitle: NSLocalizedString(
            "SEGMENTED_CONTROL_ENTRY",

nit
Typically the key parameter of a localised string is used by translators to figure out the context.
Here, "segmented control" doesn't mean anything to a non engineer.
Also it doesn't really matter that it's a segmented control, it could be anything.
A more fitting name would probably be "MULTIHOP_LABEL_ENTRY" or something similar, that is more descriptive as to which element the localization pertains.

[rablador]

Reviewable status: 3 of 7 files reviewed, 1 unresolved discussion (waiting on @buggmagnet)

---

ios/MullvadVPN/View controllers/SelectLocation/LocationViewControllerWrapper.swift line 66 at r1 (raw file):

Previously, buggmagnet wrote…

We will probably want to have accessibility on those items if we don't want to break already existing UI Tests here.
Please Make sure you run the Custom Lists UI tests when you rebase from main.

ID was added in main and custom list ui tests pass now.

---

ios/MullvadVPN/View controllers/SelectLocation/LocationViewControllerWrapper.swift line 102 at r1 (raw file):

Previously, buggmagnet wrote…

nit
Typically the key parameter of a localised string is used by translators to figure out the context.
Here, "segmented control" doesn't mean anything to a non engineer.
Also it doesn't really matter that it's a segmented control, it could be anything.
A more fitting name would probably be "MULTIHOP_LABEL_ENTRY" or something similar, that is more descriptive as to which element the localization pertains.

Done.

[acb-mv]

Reviewed 2 of 7 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)

[mojganii]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)

[mojganii]

while these changes aim to be merged into main, then we should show [select location view] with the previous design instead of the changes are coming with multi-hop like segment.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)

[buggmagnet]

Reviewed 2 of 7 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[rablador]

@mojganii If you run in mock release the segmented control will be hidden.

Reviewable status: 4 of 7 files reviewed, all discussions resolved (waiting on @acb-mv and @buggmagnet)

[mojganii]

Reviewable status: 4 of 7 files reviewed, all discussions resolved (waiting on @acb-mv and @buggmagnet)

[github-actions]

🚨 End to end tests failed. Please check the failed workflow run.