Show custom lists even if no filter constraints match #6195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rablador
force-pushed
the
custom-lists-should-always-be-visible-even-if-applied-ios-657
branch
from
e2d9ab3 to
8943caa
Compare
acb-mv
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
buggmagnet
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:
buggmagnet
force-pushed
the
custom-lists-should-always-be-visible-even-if-applied-ios-657
branch
from
8943caa to
80e8ce3
Compare
buggmagnet
deleted the
custom-lists-should-always-be-visible-even-if-applied-ios-657
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a filter is applied that excludes all constraints from a given custom list, it should still be visible in the location list view. The list should be marked as inactive, i.e. have that red circle shown in the list.
This change is