Prevent DNS leaks in blocking states or when no valid DNS has been configured #6233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pururun
approved these changes
May 8, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
This is a fix for DNS leaks in blocking states
due to an underlying OS bug where DNS queries
leak when no DNS server is configured.
Lockdown mode ("Block connections without VPN")
would also not help in this case.
More information on this issue:
https://issuetracker.google.com/issues/337961996
This is a fix for DNS leaks when no DNS server
has been configured due to an underlying OS bug.
Lockdown mode ("Block connections without VPN")
would also not help in this case.
More information on this issue:
https://issuetracker.google.com/issues/337961996
albin-mullvad
force-pushed
the
prevent-dns-leaks-in-blocking-states-droid-950
branch
from
de2a73a to
25bc197
Compare
Rawa
approved these changes
May 8, 2024
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
dlon
approved these changes
May 8, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:
hulthe
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix DNS leaks in blocking states or when no valid DNS has been configured due to an underlying OS issue. In these cases a dummy DNS will be set to prevent leaks.
More information on this issue:
https://issuetracker.google.com/issues/337961996
This change is