-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix problem report logs being duplicated #6235
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rablador)
ios/Shared/ApplicationConfiguration.swift
line 41 at r1 (raw file):
let pathIsLog = path.split(separator: ".").last == "log" // Pattern should be either "net.mullvad.MullvadVPN:PacketTunnel_" or "net.mullvad.MullvadVPN_". let pathBelongsToTarget = path.contains("\(target.bundleIdentifier)_")
I think we should write a test for that.
Also there's a small typo, it should be net.mullvad.MullvadVPN.PacketTunnel_
(dot instead of colon)
d80da60
to
df61114
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
ios/Shared/ApplicationConfiguration.swift
line 41 at r1 (raw file):
Previously, buggmagnet wrote…
I think we should write a test for that.
Also there's a small typo, it should benet.mullvad.MullvadVPN.PacketTunnel_
(dot instead of colon)
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rablador)
ios/MullvadVPNTests/MullvadLogging/LoggingTests.swift
line 18 at r2 (raw file):
override func setUpWithError() throws { try? fileManager.createDirectory(
We shouldn't try?
, if the test directory cannot be created, the tests should fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
ios/MullvadVPNTests/MullvadLogging/LoggingTests.swift
line 18 at r2 (raw file):
Previously, buggmagnet wrote…
We shouldn't
try?
, if the test directory cannot be created, the tests should fail.
Done.
df61114
to
963337e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
963337e
to
168bd35
Compare
🚨 End to end tests failed. Please check the failed workflow run. |
Some problem reports get duplicated when displaying logs in the problem report view.
This change is