Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change checkboxes in location cells to the correct ones #6248

Merged
merged 1 commit into from
May 16, 2024

Conversation

rablador
Copy link
Contributor

@rablador rablador commented May 13, 2024

The checkboxes in custom lists should be white with a green checkmark, as this is how it looks in the rest of the app. For instance in filter by provider.


This change is Reviewable

@rablador rablador added the iOS Issues related to iOS label May 13, 2024
Copy link

linear bot commented May 13, 2024

@rablador rablador requested review from mojganii, acb-mv and buggmagnet and removed request for mojganii May 15, 2024 09:11
@rablador rablador marked this pull request as ready for review May 15, 2024 09:12
Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@rablador rablador force-pushed the checkboxes-in-custom-lists-ios-676 branch from e7b42db to 8801c74 Compare May 16, 2024 13:03
@buggmagnet buggmagnet force-pushed the checkboxes-in-custom-lists-ios-676 branch from 8801c74 to 199f007 Compare May 16, 2024 13:06
Copy link
Contributor

@acb-mv acb-mv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@buggmagnet buggmagnet merged commit 0c7ee46 into main May 16, 2024
7 checks passed
@buggmagnet buggmagnet deleted the checkboxes-in-custom-lists-ios-676 branch May 16, 2024 13:17
Copy link

🚨 End to end tests failed. Please check the failed workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants