-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show spinner when consolidating logs for problem reports #6255
Show spinner when consolidating logs for problem reports #6255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rablador)
ios/MullvadVPN/View controllers/ProblemReport/ProblemReportReviewViewController.swift
line 79 at r1 (raw file):
private func loadLogs() { let presentation = AlertPresentation(
it creates a delay for log presentation which doesn't guarantee the consilating is done.is it enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)
ios/MullvadVPN/View controllers/ProblemReport/ProblemReportReviewViewController.swift
line 79 at r1 (raw file):
Previously, mojganii wrote…
it creates a delay for log presentation which doesn't guarantee the consilating is done.is it enough?
It should wait until it's done, not just a delay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)
ios/MullvadVPN/View controllers/ProblemReport/ProblemReportReviewViewController.swift
line 79 at r1 (raw file):
Previously, pinkisemils (Emīls Piņķis) wrote…
It should wait until it's done, not just a delay.
Yes, that's the idea, to wait until logs have been consolidated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pinkisemils and @rablador)
ios/MullvadVPN/View controllers/ProblemReport/ProblemReportReviewViewController.swift
line 79 at r1 (raw file):
Previously, rablador (Jon Petersson) wrote…
Yes, that's the idea, to wait until logs have been consolidated.
ok, you locked view and interaction somehow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)
ios/MullvadVPN/View controllers/ProblemReport/ProblemReportReviewViewController.swift
line 79 at r1 (raw file):
Previously, mojganii wrote…
ok, you locked view and interaction somehow.
The spinner cannot be dismissed manually, so the user has to wait. For better or worse.
282cef3
to
4aca24c
Compare
4aca24c
to
a5c3ec4
Compare
🚨 End to end tests failed. Please check the failed workflow run. |
The problem report view freezes when pressing the "view app logs" button, if many logs need to be consolidated. We should add a spinner to let the user know that everything's alright.
This change is