Remove by custom DNS by index

[Rawa]

Fixes bug where one would remove based on the current text entry instead of the index.

---

This change is 

[linear]

DROID-1030 DNS Remove is based on input, should be based on index

[Pururun]

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[Pururun]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)

---

android/lib/daemon-grpc/src/main/kotlin/net/mullvad/mullvadvpn/lib/daemon/grpc/ManagementService.kt line 351 at r1 (raw file):

                val updatedDnsOptions =
                    DnsOptions.customOptions.addresses.modify(currentDnsOptions) {
                        it.filterIndexed { i, _ -> i != index }

Just a thought, would it be more clear to show what we are doing by doing something like:
it.toMutableList().apply { removeAt(1) } ?

[Pururun]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)

---

android/lib/daemon-grpc/src/main/kotlin/net/mullvad/mullvadvpn/lib/daemon/grpc/ManagementService.kt line 351 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

Just a thought, would it be more clear to show what we are doing by doing something like:
it.toMutableList().apply { removeAt(1) } ?

Should be removeAt(index)

[Rawa]

Reviewable status: 4 of 5 files reviewed, all discussions resolved (waiting on @Pururun)

---

android/lib/daemon-grpc/src/main/kotlin/net/mullvad/mullvadvpn/lib/daemon/grpc/ManagementService.kt line 351 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

Should be removeAt(index)

Thanks, clarified.

[Pururun]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved