Add setting for udp2tcp port

[Rawa]

---

This change is 

[linear]

DROID-249 Add setting for udp2tcp port

[Pururun]

Reviewed 34 of 34 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Rawa)

---

android/app/src/androidTest/kotlin/net/mullvad/mullvadvpn/compose/screen/VpnSettingsScreenTest.kt line 212 at r1 (raw file):

    @Test
    fun testShowTcpOverUdpPortOptions() =

Maybe we should have some tests so that you can not set the port when udp over tcp is not available?

---

android/app/src/androidTest/kotlin/net/mullvad/mullvadvpn/compose/screen/VpnSettingsScreenTest.kt line 456 at r1 (raw file):

            // Assert
            verify(exactly = 1) { mockedNavigateToObfuscationInfo() }

Just a side not, but could be nice with a verifyExactlyOnce function, or maybe that is too verbose?

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/VpnSettingsScreen.kt line 594 at r1 (raw file):

            itemWithDivider {
                ExpandableComposeCell(

Should show disabled somehow and should not be able to change port if udp over tcp is disabled

[Pururun]

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @Rawa)

---

android/lib/daemon-grpc/src/main/kotlin/net/mullvad/mullvadvpn/lib/daemon/grpc/ManagementService.kt line 389 at r1 (raw file):

            .mapEmpty()

    suspend fun setObfuscationPort(

This function looks quite complicated, can we not wrap the whole this in an either catch?

[Rawa]

Reviewable status: 28 of 36 files reviewed, 3 unresolved discussions (waiting on @Pururun)

---

android/app/src/androidTest/kotlin/net/mullvad/mullvadvpn/compose/screen/VpnSettingsScreenTest.kt line 212 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

Maybe we should have some tests so that you can not set the port when udp over tcp is not available?

Added a test for this.

---

android/app/src/androidTest/kotlin/net/mullvad/mullvadvpn/compose/screen/VpnSettingsScreenTest.kt line 456 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

Just a side not, but could be nice with a verifyExactlyOnce function, or maybe that is too verbose?

Too verbose I think, lets just use the simple standard way.

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/VpnSettingsScreen.kt line 594 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

Should show disabled somehow and should not be able to change port if udp over tcp is disabled

Yes it totally should! Fixed!

---

android/lib/daemon-grpc/src/main/kotlin/net/mullvad/mullvadvpn/lib/daemon/grpc/ManagementService.kt line 389 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

This function looks quite complicated, can we not wrap the whole this in an either catch?

Fixed!

[Pururun]

Reviewed 8 of 8 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved