Add multi-hop toggle to settings view

[mojganii]

This PR allows users to change the multi-hop state in the settings view.

Before	After

---

This change is 

[linear]

IOS-687 Add multihop toggle to settings view

[buggmagnet]

The cell stays selected if I tap on it, we should disable selection for this specific cell.
MultiSelect.mov

Reviewed 9 of 24 files at r1, all commit messages.
Reviewable status: 9 of 24 files reviewed, 3 unresolved discussions (waiting on @mojganii)

---

ios/MullvadREST/Transport/Shadowsocks/ShadowsocksLoader.swift line 56 at r1 (raw file):
nit:

if the multihop settings have changed

---

ios/MullvadVPN/View controllers/VPNSettings/CustomDNSDataSource.swift line 123 at r1 (raw file):

    private weak var tableView: UITableView?

    weak var delegate: DnsSettingsDataSourceDelegate?

nit
It should be DNSSettingsDataSourceDelegate?

---

ios/MullvadVPN/View controllers/VPNSettings/VPNSettingsDataSourceDelegate.swift line 23 at r1 (raw file):

    func showIPOverrides()
    func didSelectWireGuardPort(_ port: UInt16?)
    func showMultihopConfirmation(_ onSave: @escaping () -> Void, _ onDiscard: @escaping () -> Void)

We should leave the name arguments here, otherwise, it's really hard to tell which closure will do what on the call site.

[buggmagnet]

Reviewable status: 9 of 24 files reviewed, 4 unresolved discussions (waiting on @mojganii)

---

ios/PacketTunnel/PacketTunnelProvider/PacketTunnelProvider.swift line 245 at r1 (raw file):

            for await newState in stateStream {
                // Pass relay constraints retrieved during the last read from setting into transport provider.
                if let relayConstraints = newState.relayConstraints {

Why was this line removed ?

[mojganii]

Reviewable status: 9 of 24 files reviewed, 3 unresolved discussions (waiting on @buggmagnet)

---

ios/MullvadREST/Transport/Shadowsocks/ShadowsocksLoader.swift line 56 at r1 (raw file):

Previously, buggmagnet wrote…

nit:

if the multihop settings have changed

done

---

ios/MullvadVPN/View controllers/VPNSettings/CustomDNSDataSource.swift line 123 at r1 (raw file):

Previously, buggmagnet wrote…

nit
It should be DNSSettingsDataSourceDelegate?

Right, it's acronym.

---

ios/MullvadVPN/View controllers/VPNSettings/VPNSettingsDataSourceDelegate.swift line 23 at r1 (raw file):

Previously, buggmagnet wrote…

We should leave the name arguments here, otherwise, it's really hard to tell which closure will do what on the call site.

indeed!

---

ios/PacketTunnel/PacketTunnelProvider/PacketTunnelProvider.swift line 245 at r1 (raw file):

Previously, buggmagnet wrote…

Why was this line removed ?

we are tracking the value or relay constraints above. we don't need fetch that from connection state.

[buggmagnet]

Reviewed 3 of 8 files at r2.
Reviewable status: 9 of 24 files reviewed, 2 unresolved discussions

[buggmagnet]

Reviewable status: 9 of 24 files reviewed, 1 unresolved discussion

[github-actions]

🚨 End to end tests failed. Please check the failed workflow run.