Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent title from being multiple lines #6350

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Jun 14, 2024


This change is Reviewable

Copy link

linear bot commented Jun 14, 2024

@Rawa Rawa self-assigned this Jun 14, 2024
@Rawa Rawa added the Android Issues related to Android label Jun 14, 2024
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)


-- commits line 2 at r1:
I thinks this should clarify which title being constrained.

@Rawa Rawa force-pushed the vpn-permission-error-title-is-using-two-rows-droid-894 branch from a2e177e to 88084d1 Compare June 14, 2024 07:41
Copy link
Contributor Author

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)


-- commits line 2 at r1:

Previously, Pururun (Jonatan Rhodin) wrote…

I thinks this should clarify which title being constrained.

Done.

@Rawa Rawa requested a review from Pururun June 14, 2024 07:46
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion

@Rawa Rawa force-pushed the vpn-permission-error-title-is-using-two-rows-droid-894 branch from 88084d1 to dd64b01 Compare June 14, 2024 07:52
@Rawa Rawa merged commit 9e9b69a into main Jun 14, 2024
20 of 22 checks passed
@Rawa Rawa deleted the vpn-permission-error-title-is-using-two-rows-droid-894 branch June 14, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants