Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text overflow and max lines on connection screen #6351

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Jun 14, 2024


This change is Reviewable

Copy link

linear bot commented Jun 14, 2024

@Rawa Rawa self-assigned this Jun 14, 2024
@Rawa Rawa added the Android Issues related to Android label Jun 14, 2024
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)


-- commits line 2 at r1:
Should probably mention that this is in the connect screen.

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)

@Rawa Rawa force-pushed the line-break-in-status-text-causes-map-to-move-droid-1045 branch from 0720a4d to ccbc0c6 Compare June 14, 2024 07:40
Copy link
Contributor Author

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)


-- commits line 2 at r1:

Previously, Pururun (Jonatan Rhodin) wrote…

Should probably mention that this is in the connect screen.

Fixed

Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Rawa Rawa force-pushed the line-break-in-status-text-causes-map-to-move-droid-1045 branch from ccbc0c6 to 45d6831 Compare June 14, 2024 07:53
@Rawa Rawa merged commit f383f72 into main Jun 14, 2024
18 checks passed
@Rawa Rawa deleted the line-break-in-status-text-causes-map-to-move-droid-1045 branch June 14, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants