Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action to ensure clean lockfile #6361

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

albin-mullvad
Copy link
Collaborator

@albin-mullvad albin-mullvad commented Jun 17, 2024

This PR aims to add an action which ensure that the lockfile is in a clean state. It also makes it possible to run the lockfile script without podman.


This change is Reviewable

@albin-mullvad albin-mullvad added the Android Issues related to Android label Jun 17, 2024
@albin-mullvad albin-mullvad self-assigned this Jun 17, 2024
Copy link

linear bot commented Jun 17, 2024

This makes it easier to use the script in a
wider range of environments and if needed it
can still be executed within a container.
@albin-mullvad albin-mullvad force-pushed the add-action-to-ensure-clean-lockfile-droid-669 branch from 5768c49 to 8e83fef Compare June 17, 2024 12:20
@albin-mullvad albin-mullvad force-pushed the add-action-to-ensure-clean-lockfile-droid-669 branch from 8e83fef to bd19bac Compare June 17, 2024 13:06
@albin-mullvad albin-mullvad marked this pull request as ready for review June 17, 2024 13:07
@albin-mullvad albin-mullvad requested a review from Pururun June 17, 2024 13:07
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@albin-mullvad albin-mullvad merged commit 55e2277 into main Jun 17, 2024
28 checks passed
@albin-mullvad albin-mullvad deleted the add-action-to-ensure-clean-lockfile-droid-669 branch June 17, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants