Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix protoc dependency verification #6364

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Fix protoc dependency verification #6364

merged 2 commits into from
Jun 17, 2024

Conversation

Pururun
Copy link
Contributor

@Pururun Pururun commented Jun 17, 2024

Currently we have an issue that the verification file only includes hashes for the platform that was used for the generation. This fixes that issue by always including all supported platforms.

Fixes DROID-1068


This change is Reviewable

@Pururun Pururun requested a review from albin-mullvad June 17, 2024 13:54
@Pururun Pururun changed the title Fix protoc dependencies Fix protoc dependency verification Jun 17, 2024
@Pururun Pururun added the Android Issues related to Android label Jun 17, 2024
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun merged commit e19b1f3 into main Jun 17, 2024
32 checks passed
@Pururun Pururun deleted the fix-protoc-dependencies branch June 17, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants