-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use temp dirs in lockfile script #6365
Use temp dirs in lockfile script #6365
Conversation
5896d18
to
1bc94a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @albin-mullvad)
android/scripts/update-lockfile.sh
line 11 at r3 (raw file):
# regardless if stopped. GRADLE_OPTS="-Dorg.gradle.daemon=false" GRADLE_USER_HOME=$(mktemp -d -t gradle-home-XXX)
Should we add a comment that -t
is needed because of OSX?
android/scripts/update-lockfile.sh
line 26 at r3 (raw file):
echo "### Updating dependency lockfile ###" echo "Gradle home: $GRADLE_USER_HOME"
Maybe remove these since they are mostly for debugging?
1bc94a9
to
535a073
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @Pururun)
android/scripts/update-lockfile.sh
line 11 at r3 (raw file):
Previously, Pururun (Jonatan Rhodin) wrote…
Should we add a comment that
-t
is needed because of OSX?
Done!
android/scripts/update-lockfile.sh
line 26 at r3 (raw file):
Previously, Pururun (Jonatan Rhodin) wrote…
Maybe remove these since they are mostly for debugging?
Doesn't hurt much and would be nice to keep since we've had tons of strange issues generating the lockfile and otherwise might have a hard time debugging in some scenarios such as GH actions. Sounds OK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
android/scripts/update-lockfile.sh
line 26 at r3 (raw file):
Previously, albin-mullvad wrote…
Doesn't hurt much and would be nice to keep since we've had tons of strange issues generating the lockfile and otherwise might have a hard time debugging in some scenarios such as GH actions. Sounds OK?
It is ok with me :)
This PR aims to automatically use temp dirs in the lockfile script.
This change is