Update README in gui/scripts #6370
Conversation
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @raksooo)
gui/scripts/README.md line 17 at r1 (raw file):
### Update translations See [../locales/README.md](../locales/README.md) for information about how to handle translations.
Nit We could skip the .. when formatting the link
See [locales/README.md](../locales/README.md)
Code quote:
See [../locales/README.md](../locales/README.md) gui/scripts/README.md line 19 at r1 (raw file):
See [../locales/README.md](../locales/README.md) for information about how to handle translations. The `/scripts/localization` script is, among other things, calling into `fetch-relay-locations.py`
Nit Is / how we are supposed to refer to the project root in documentation? 😊
Would it be less clear if we replaced /scripts/localization with scripts/localization?
Code quote:
The `/scripts/localization`gui/scripts/README.md line 24 at r1 (raw file):
* `fetch-relay-locations.py` fetches the relay list and extracts all country and city names. * `intregrate-relay-locations.py` integrates the fetched relay locations into `../locales/relay-locations.pot`.
Nit Either make this a markdown link, or format it relative to the project root:
gui/locales/relay-locations.pot
Code quote:
../locales/relay-locations.pot
raksooo
force-pushed
the
improve-gui-scripts-readme
branch
from
023ff38 to
037ba89
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @MarkusPettersson98)
gui/scripts/README.md line 17 at r1 (raw file):
Previously, MarkusPettersson98 (Markus Pettersson) wrote…
Nit We could skip the
..when formatting the linkSee [locales/README.md](../locales/README.md)
Done.
gui/scripts/README.md line 19 at r1 (raw file):
Previously, MarkusPettersson98 (Markus Pettersson) wrote…
Nit Is
/how we are supposed to refer to the project root in documentation? 😊
Would it be less clear if we replaced/scripts/localizationwithscripts/localization?
Done.
gui/scripts/README.md line 24 at r1 (raw file):
Previously, MarkusPettersson98 (Markus Pettersson) wrote…
Nit Either make this a markdown link, or format it relative to the project root:
gui/locales/relay-locations.pot
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
raksooo
force-pushed
the
improve-gui-scripts-readme
branch
from
037ba89 to
0683ec1
Compare
This PR updates the readme in
gui/scriptsto reflect the changes made to the localization scripts in #6241.This change is