Add support for bullets in changes file

[Pururun]

---

This change is 

[linear]

DROID-1064 Add support for bullets in changes file

[albin-mullvad]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/util/StringExtensions.kt line 16 at r1 (raw file):

    Html.fromHtml(this, HtmlCompat.FROM_HTML_MODE_LEGACY).toString()

fun List<String>.trim() = map { it.trim() }

I suggest renaming to trimAll

Code quote:

trim

[Pururun]

Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/util/StringExtensions.kt line 16 at r1 (raw file):

Previously, albin-mullvad wrote…

I suggest renaming to trimAll

Done.

[albin-mullvad]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[Rawa]

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/repository/ChangelogRepository.kt line 29 at r3 (raw file):

            .getChangelog()
            .split(BULLET_POINT_CHAR)
            .map { it.split(NEWLINE_CHAR).trimAll().fastJoinToString(SPACE_STRING).trim() }

Not sure what we feel about fastJoinToString it comes from the compose.ui.util package, do we see a good purpose to have it? Or should we just use the normal joinToString?

[Pururun]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/repository/ChangelogRepository.kt line 29 at r3 (raw file):

Previously, Rawa (David Göransson) wrote…

Not sure what we feel about fastJoinToString it comes from the compose.ui.util package, do we see a good purpose to have it? Or should we just use the normal joinToString?

No it was just me that was confused and though it was part of some kotlin library instead of compose. Changed it to joinToString

[Rawa]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved