Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compose to 1.7.0-beta3 #6393

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Update compose to 1.7.0-beta3 #6393

merged 4 commits into from
Jun 25, 2024

Conversation

Pururun
Copy link
Contributor

@Pururun Pururun commented Jun 20, 2024

Also updates the following plugins and libraries:

kotlinCompilerExtensionVersion -> 1.5.14
appcompat -> 1.7.0
compose-material3 -> 1.3.0-beta03
kotlin -> 1.9.24
ksp -> 1.0.20
grpc -> 1.64.0

This is to fix the app crashing on release builds.


This change is Reviewable

@Pururun Pururun requested a review from albin-mullvad June 20, 2024 14:11
Copy link

linear bot commented Jun 20, 2024

@Pururun Pururun added the Android Issues related to Android label Jun 20, 2024
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 7 files at r1, all commit messages.
Reviewable status: 6 of 7 files reviewed, all discussions resolved

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 6 of 7 files reviewed, all discussions resolved

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 7 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun force-pushed the crash-on-first-start-droid-1090 branch from c271a27 to f83b67b Compare June 20, 2024 14:49
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@albin-mullvad albin-mullvad force-pushed the crash-on-first-start-droid-1090 branch from f83b67b to f76214f Compare June 20, 2024 15:08
Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Rawa Rawa mentioned this pull request Jun 24, 2024
@Pururun Pururun force-pushed the crash-on-first-start-droid-1090 branch 2 times, most recently from de3b361 to 43b8e30 Compare June 24, 2024 14:10
Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun force-pushed the crash-on-first-start-droid-1090 branch from 43b8e30 to 61dfddf Compare June 25, 2024 10:02
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r6, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun force-pushed the crash-on-first-start-droid-1090 branch from 61dfddf to 128998c Compare June 25, 2024 10:07
Pururun added 4 commits June 25, 2024 15:08
Also update some related libraries that were required

This fixes a crash on release build
@Pururun Pururun force-pushed the crash-on-first-start-droid-1090 branch from 128998c to 79b06d0 Compare June 25, 2024 13:09
@Pururun Pururun merged commit a2150d2 into main Jun 25, 2024
28 checks passed
@Pururun Pururun deleted the crash-on-first-start-droid-1090 branch June 25, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants