Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DAITA on macOS #6410

Merged
merged 4 commits into from
Jun 26, 2024
Merged

Add DAITA on macOS #6410

merged 4 commits into from
Jun 26, 2024

Conversation

dlon
Copy link
Member

@dlon dlon commented Jun 26, 2024

See #6408 for more details.

Fix DES-785.
Fix DES-784.


This change is Reviewable

@dlon dlon requested a review from MarkusPettersson98 June 26, 2024 08:03
Copy link

linear bot commented Jun 26, 2024

@dlon dlon changed the title Enable DAITA for macOS Add DAITA on macOS Jun 26, 2024
@dlon dlon force-pushed the add-macos-daita branch 2 times, most recently from 5fcc46e to 5a70576 Compare June 26, 2024 08:20
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 18 of 18 files at r1, 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 7 unresolved discussions (waiting on @dlon)


mullvad-cli/build.rs line 20 at r1 (raw file):

    let target_os = std::env::var("CARGO_CFG_TARGET_OS").expect("CARGO_CFG_TARGET_OS not set");

    // Enable Daita by default on Linux and Windows.

Comment is outdated

Code quote:

// Enable Daita by default on Linux and Windows.

mullvad-daemon/build.rs line 34 at r1 (raw file):

    let target_os = std::env::var("CARGO_CFG_TARGET_OS").expect("CARGO_CFG_TARGET_OS not set");

    // Enable Daita by default on Linux and Windows.

Comment is outdated

Code quote:

// Enable Daita by default on Linux and Windows.

mullvad-management-interface/build.rs line 6 at r1 (raw file):

    let target_os = std::env::var("CARGO_CFG_TARGET_OS").expect("CARGO_CFG_TARGET_OS not set");

    // Enable Daita by default on Linux and Windows.

Comment is outdated

Code quote:

// Enable Daita by default on Linux and Windows.

mullvad-relay-selector/build.rs line 4 at r1 (raw file):

    let target_os = std::env::var("CARGO_CFG_TARGET_OS").expect("CARGO_CFG_TARGET_OS not set");

    // Enable Daita by default on Linux and Windows.

Comment is outdated

Code quote:

// Enable Daita by default on Linux and Windows.

mullvad-types/build.rs line 4 at r1 (raw file):

    let target_os = std::env::var("CARGO_CFG_TARGET_OS").expect("CARGO_CFG_TARGET_OS not set");

    // Enable Daita by default on Linux and Windows.

Comment is outdated

Code quote:

// Enable Daita by default on Linux and Windows.

talpid-types/build.rs line 4 at r1 (raw file):

    let target_os = std::env::var("CARGO_CFG_TARGET_OS").expect("CARGO_CFG_TARGET_OS not set");

    // Enable Daita by default on Linux and Windows.

Comment is outdated

Code quote:

// Enable Daita by default on Linux and Windows.

talpid-wireguard/build.rs line 17 at r1 (raw file):

    }

    // Enable Daita by default on Linux and Windows.

Comment is outdated

Code quote:

// Enable Daita by default on Linux and Windows.

@dlon dlon force-pushed the add-macos-daita branch from 5a70576 to 0c2cddc Compare June 26, 2024 08:35
Copy link
Member Author

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 11 of 18 files reviewed, 7 unresolved discussions (waiting on @MarkusPettersson98)


mullvad-cli/build.rs line 20 at r1 (raw file):

Previously, MarkusPettersson98 (Markus Pettersson) wrote…

Comment is outdated

Done.


mullvad-daemon/build.rs line 34 at r1 (raw file):

Previously, MarkusPettersson98 (Markus Pettersson) wrote…

Comment is outdated

Done.


mullvad-management-interface/build.rs line 6 at r1 (raw file):

Previously, MarkusPettersson98 (Markus Pettersson) wrote…

Comment is outdated

Done.


mullvad-relay-selector/build.rs line 4 at r1 (raw file):

Previously, MarkusPettersson98 (Markus Pettersson) wrote…

Comment is outdated

Done.


mullvad-types/build.rs line 4 at r1 (raw file):

Previously, MarkusPettersson98 (Markus Pettersson) wrote…

Comment is outdated

Done.


talpid-types/build.rs line 4 at r1 (raw file):

Previously, MarkusPettersson98 (Markus Pettersson) wrote…

Comment is outdated

Done.


talpid-wireguard/build.rs line 17 at r1 (raw file):

Previously, MarkusPettersson98 (Markus Pettersson) wrote…

Comment is outdated

Done.

Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dlon dlon merged commit ac70101 into main Jun 26, 2024
58 checks passed
@dlon dlon deleted the add-macos-daita branch June 26, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants