-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DAITA on macOS #6410
Add DAITA on macOS #6410
Conversation
5fcc46e
to
5a70576
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 18 of 18 files at r1, 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 7 unresolved discussions (waiting on @dlon)
mullvad-cli/build.rs
line 20 at r1 (raw file):
let target_os = std::env::var("CARGO_CFG_TARGET_OS").expect("CARGO_CFG_TARGET_OS not set"); // Enable Daita by default on Linux and Windows.
Comment is outdated
Code quote:
// Enable Daita by default on Linux and Windows.
mullvad-daemon/build.rs
line 34 at r1 (raw file):
let target_os = std::env::var("CARGO_CFG_TARGET_OS").expect("CARGO_CFG_TARGET_OS not set"); // Enable Daita by default on Linux and Windows.
Comment is outdated
Code quote:
// Enable Daita by default on Linux and Windows.
mullvad-management-interface/build.rs
line 6 at r1 (raw file):
let target_os = std::env::var("CARGO_CFG_TARGET_OS").expect("CARGO_CFG_TARGET_OS not set"); // Enable Daita by default on Linux and Windows.
Comment is outdated
Code quote:
// Enable Daita by default on Linux and Windows.
mullvad-relay-selector/build.rs
line 4 at r1 (raw file):
let target_os = std::env::var("CARGO_CFG_TARGET_OS").expect("CARGO_CFG_TARGET_OS not set"); // Enable Daita by default on Linux and Windows.
Comment is outdated
Code quote:
// Enable Daita by default on Linux and Windows.
mullvad-types/build.rs
line 4 at r1 (raw file):
let target_os = std::env::var("CARGO_CFG_TARGET_OS").expect("CARGO_CFG_TARGET_OS not set"); // Enable Daita by default on Linux and Windows.
Comment is outdated
Code quote:
// Enable Daita by default on Linux and Windows.
talpid-types/build.rs
line 4 at r1 (raw file):
let target_os = std::env::var("CARGO_CFG_TARGET_OS").expect("CARGO_CFG_TARGET_OS not set"); // Enable Daita by default on Linux and Windows.
Comment is outdated
Code quote:
// Enable Daita by default on Linux and Windows.
talpid-wireguard/build.rs
line 17 at r1 (raw file):
} // Enable Daita by default on Linux and Windows.
Comment is outdated
Code quote:
// Enable Daita by default on Linux and Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 11 of 18 files reviewed, 7 unresolved discussions (waiting on @MarkusPettersson98)
mullvad-cli/build.rs
line 20 at r1 (raw file):
Previously, MarkusPettersson98 (Markus Pettersson) wrote…
Comment is outdated
Done.
mullvad-daemon/build.rs
line 34 at r1 (raw file):
Previously, MarkusPettersson98 (Markus Pettersson) wrote…
Comment is outdated
Done.
mullvad-management-interface/build.rs
line 6 at r1 (raw file):
Previously, MarkusPettersson98 (Markus Pettersson) wrote…
Comment is outdated
Done.
mullvad-relay-selector/build.rs
line 4 at r1 (raw file):
Previously, MarkusPettersson98 (Markus Pettersson) wrote…
Comment is outdated
Done.
mullvad-types/build.rs
line 4 at r1 (raw file):
Previously, MarkusPettersson98 (Markus Pettersson) wrote…
Comment is outdated
Done.
talpid-types/build.rs
line 4 at r1 (raw file):
Previously, MarkusPettersson98 (Markus Pettersson) wrote…
Comment is outdated
Done.
talpid-wireguard/build.rs
line 17 at r1 (raw file):
Previously, MarkusPettersson98 (Markus Pettersson) wrote…
Comment is outdated
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
See #6408 for more details.
Fix DES-785.
Fix DES-784.
This change is