-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inconsistent spacing between paragraphs #6422
Fix inconsistent spacing between paragraphs #6422
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 10 files reviewed, 1 unresolved discussion
ios/MullvadVPN/Coordinators/ApplicationCoordinator.swift
line 416 at r1 (raw file):
guard let self else { return } router.dismissAll(.primary, animated: true) DispatchQueue.main.async {
Opportunistically fixed an unrelated bug where logging out from add voucher screen would crash due to doing UI work on background thread.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 10 files at r1.
Reviewable status: 9 of 10 files reviewed, 2 unresolved discussions (waiting on @rablador)
ios/MullvadVPN/View controllers/VPNSettings/CustomDNSViewController.swift
line 116 at r1 (raw file):
domains or websites known for distributing ads, malware, trackers and more. \ This might cause issues on certain websites, services, and apps.
I think this new line was intentionally there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 9 of 10 files reviewed, 2 unresolved discussions (waiting on @buggmagnet)
ios/MullvadVPN/View controllers/VPNSettings/CustomDNSViewController.swift
line 116 at r1 (raw file):
Fixed
ae87692
to
ff84ca3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 10 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions
ff84ca3
to
3718351
Compare
3718351
to
b57069e
Compare
A few places in the app has inconsistent spacing between paragraphs. This PR addresses that and creates a common style to share.
This change is