Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent spacing between paragraphs #6422

Conversation

rablador
Copy link
Contributor

@rablador rablador commented Jun 27, 2024

A few places in the app has inconsistent spacing between paragraphs. This PR addresses that and creates a common style to share.


This change is Reviewable

@rablador rablador added the iOS Issues related to iOS label Jun 27, 2024
@rablador rablador requested review from buggmagnet and mojganii June 27, 2024 12:50
@rablador rablador self-assigned this Jun 27, 2024
Copy link
Contributor Author

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 10 files reviewed, 1 unresolved discussion


ios/MullvadVPN/Coordinators/ApplicationCoordinator.swift line 416 at r1 (raw file):

            guard let self else { return }
            router.dismissAll(.primary, animated: true)
            DispatchQueue.main.async {

Opportunistically fixed an unrelated bug where logging out from add voucher screen would crash due to doing UI work on background thread.

Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 10 files at r1.
Reviewable status: 9 of 10 files reviewed, 2 unresolved discussions (waiting on @rablador)


ios/MullvadVPN/View controllers/VPNSettings/CustomDNSViewController.swift line 116 at r1 (raw file):

                domains or websites known for distributing ads, malware, trackers and more. \
                This might cause issues on certain websites, services, and apps.

I think this new line was intentionally there

Before
IMG_8327.PNG

After
IMG_8328.PNG

Copy link
Contributor Author

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 9 of 10 files reviewed, 2 unresolved discussions (waiting on @buggmagnet)


ios/MullvadVPN/View controllers/VPNSettings/CustomDNSViewController.swift line 116 at r1 (raw file):

Previously, buggmagnet wrote…

I think this new line was intentionally there

Before
IMG_8327.PNG

After
IMG_8328.PNG

Fixed

@rablador rablador force-pushed the fix-the-abnormal-spacing-between-lines-in-the-device-info-ios-732 branch 2 times, most recently from ae87692 to ff84ca3 Compare July 1, 2024 12:07
Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 10 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions

@rablador rablador force-pushed the fix-the-abnormal-spacing-between-lines-in-the-device-info-ios-732 branch from ff84ca3 to 3718351 Compare July 2, 2024 08:05
@pinkisemils pinkisemils force-pushed the fix-the-abnormal-spacing-between-lines-in-the-device-info-ios-732 branch from 3718351 to b57069e Compare July 10, 2024 14:37
@pinkisemils pinkisemils merged commit c64351f into main Jul 10, 2024
8 of 9 checks passed
@pinkisemils pinkisemils deleted the fix-the-abnormal-spacing-between-lines-in-the-device-info-ios-732 branch July 10, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants