Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android splash screen #6424

Merged
merged 3 commits into from
Jul 4, 2024
Merged

Android splash screen #6424

merged 3 commits into from
Jul 4, 2024

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Jun 28, 2024


This change is Reviewable

@Rawa Rawa force-pushed the android-splash-screen branch from 8a9aab9 to 0c1feb2 Compare June 28, 2024 13:24
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 11 files at r1, all commit messages.
Reviewable status: 9 of 11 files reviewed, 4 unresolved discussions (waiting on @Rawa)


android/app/src/main/kotlin/net/mullvad/mullvadvpn/di/UiModule.kt line 143 at r1 (raw file):

    single { FilteredRelayListUseCase(get(), get()) }
    single { LastKnownLocationUseCase(get()) }
    single { SplashCompleteRepository() }

nit: move to other repositories


android/app/src/main/kotlin/net/mullvad/mullvadvpn/repository/SplashCompleteRepository.kt line 6 at r1 (raw file):

class SplashCompleteRepository {
    private val _splashComplete = MutableStateFlow(false)

Does this need to be a stateflow?


android/lib/resource/src/main/res/values-v33/styles.xml line 2 at r1 (raw file):

<?xml version="1.0" encoding="utf-8"?>
<resources>

We might need to update the paths in android/scripts/tidy.sh for this PR. Please double check!


android/lib/resource/src/main/res/values-v33/styles.xml line 17 at r1 (raw file):

        <item name="android:windowSplashScreenBehavior">icon_preferred</item>
    </style>
</resources>

Bad EOF?

@albin-mullvad albin-mullvad added the Android Issues related to Android label Jun 28, 2024
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 9 of 11 files reviewed, 5 unresolved discussions (waiting on @Rawa)


android/app/src/main/kotlin/net/mullvad/mullvadvpn/viewmodel/SplashViewModel.kt line 35 at r1 (raw file):

    }

    private val _mutableUiState = MutableStateFlow<SplashScreenState>(SplashScreenState(false))

nit: _uiState

Code quote:

_mutableUiState

Copy link
Contributor Author

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 5 of 15 files reviewed, 2 unresolved discussions (waiting on @albin-mullvad)


android/app/src/main/kotlin/net/mullvad/mullvadvpn/repository/SplashCompleteRepository.kt line 6 at r1 (raw file):

Previously, albin-mullvad wrote…

Does this need to be a stateflow?

Done.


android/lib/resource/src/main/res/values-v33/styles.xml line 17 at r1 (raw file):

Previously, albin-mullvad wrote…

Bad EOF?

Done.

@Rawa Rawa force-pushed the android-splash-screen branch from f197a31 to 227144b Compare July 1, 2024 13:24
@Rawa Rawa requested a review from albin-mullvad July 1, 2024 13:24
@Rawa Rawa self-assigned this Jul 2, 2024
@Rawa Rawa force-pushed the android-splash-screen branch from 227144b to 0dad938 Compare July 3, 2024 14:22
@Rawa Rawa force-pushed the android-splash-screen branch from 0dad938 to c793ac5 Compare July 4, 2024 08:22
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 16 of 16 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Rawa Rawa force-pushed the android-splash-screen branch from c793ac5 to d23e892 Compare July 4, 2024 10:09
@Rawa Rawa merged commit c59d28f into main Jul 4, 2024
26 of 28 checks passed
@Rawa Rawa deleted the android-splash-screen branch July 4, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants