Remove update available message

[albin-mullvad]

This PR aims to remove the update available message from the in-app notification and settings. Instead of showing it in settings we'll instead just show the unsupported message.

---

This change is 

[linear]

DROID-1103 Only show unsupported version in settings

[Rawa]

Reviewed 29 of 32 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @albin-mullvad)

---

android/app/src/androidTest/kotlin/net/mullvad/mullvadvpn/compose/screen/SettingsScreenTest.kt line 34 at r2 (raw file):

                            appVersion = "",
                            isLoggedIn = true,
                            isUnsupportedVersion = false,

Personally I think it is nicer to say isSupportedVersion instead of isUnsupportedVersion but I understand that we do actually care about if it is Unsupported, not the other way around.

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/cell/NavigationComposeCell.kt line 97 at r2 (raw file):

            painter = painterResource(id = R.drawable.icon_alert),
            modifier = Modifier.padding(end = Dimens.smallPadding),
            contentDescription = ""

Should be null if it is empty string.

Not sure why we use Image here, sure it is very similar to Icon but Icon is more intuitive. Created a ticket for us to fix uses of Image.

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/DeviceListScreen.kt line 165 at r2 (raw file):

            dropUnlessResumed<Device> {
                // Logger.i("DeviceList: remove device: $it")
                Log.d("mullvad", "DeviceList: remove device: $it")

Remove? bad log?

[albin-mullvad]

Reviewable status: 24 of 37 files reviewed, 2 unresolved discussions (waiting on @Rawa)

---

android/app/src/androidTest/kotlin/net/mullvad/mullvadvpn/compose/screen/SettingsScreenTest.kt line 34 at r2 (raw file):

Previously, Rawa (David Göransson) wrote…

Personally I think it is nicer to say isSupportedVersion instead of isUnsupportedVersion but I understand that we do actually care about if it is Unsupported, not the other way around.

Yeah, I agree. Fixed!

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/cell/NavigationComposeCell.kt line 97 at r2 (raw file):

Previously, Rawa (David Göransson) wrote…

Should be null if it is empty string.

Not sure why we use Image here, sure it is very similar to Icon but Icon is more intuitive. Created a ticket for us to fix uses of Image.

Fixed for now 👍 Let's improve as part of the new ticket

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/DeviceListScreen.kt line 165 at r2 (raw file):

Previously, Rawa (David Göransson) wrote…

Remove? bad log?

Yeah, removed! 😄 committed by mistake when debugging the other issue I found

[Rawa]

Reviewed 13 of 13 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved