Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge branch 'bump-android-test-dependencies'" #6453

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Jul 8, 2024

This reverts commit 9098624, reversing changes made to 312f5d2. The previous merge caused tests to generate false-positive test results.

Here is a example of a run with the false positive output


This change is Reviewable

@Rawa Rawa self-assigned this Jul 8, 2024
@Rawa Rawa added the Android Issues related to Android label Jul 8, 2024
@Rawa Rawa force-pushed the revert-bump-test-dependencies branch from 99ee2e2 to 6bb8530 Compare July 8, 2024 12:40
@Rawa Rawa requested a review from pinkisemils July 9, 2024 13:49
Copy link
Collaborator

@pinkisemils pinkisemils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Collaborator

@pinkisemils pinkisemils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Rawa Rawa force-pushed the revert-bump-test-dependencies branch from 4b69597 to 4fefb54 Compare July 10, 2024 10:04
@Rawa Rawa force-pushed the revert-bump-test-dependencies branch from 4fefb54 to 24c753a Compare July 10, 2024 10:27
@Rawa Rawa merged commit 6e7a642 into main Jul 10, 2024
28 of 29 checks passed
@Rawa Rawa deleted the revert-bump-test-dependencies branch July 10, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants