Implement feature indicators in daemon

[hulthe]

• Add a GetFeatureIndicators gRPC call that get's the current set of active "features" that should be shown in the UI.
• Extend the DaemonEvent gRPC stream with a FeatureIndicators variant that has the same info.

---

This change is 

[linear]

DES-1082 Implement feature indicators in RPC

[Rawa]

Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @hulthe)

---

android/lib/daemon-grpc/src/main/kotlin/net/mullvad/mullvadvpn/lib/daemon/grpc/ManagementService.kt line 226 at r1 (raw file):

                        ManagementInterface.DaemonEvent.EventCase.REMOVE_DEVICE -> {}
                        ManagementInterface.DaemonEvent.EventCase.EVENT_NOT_SET -> {}
                        ManagementInterface.DaemonEvent.EventCase.FEATURE_INDICATORS -> {}

[Serock3]

Maybe this should just be a tuple struct so we avoid having to name the only field? I.e. FeatureIndicators(HashSet<FeatureIndicator>).

[MarkusPettersson98]

Might as well tbh

[Serock3]

There seems to be no code for triggering a new TunnelState when a setting changes that affects feature indicators, but not the tunnelstate itself, e.g. lockdown mode. You likely still have to listen to changes to the settings to capture this.

Reviewed 8 of 11 files at r3, 3 of 3 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @hulthe)

---

mullvad-cli/src/format.rs line 25 at r4 (raw file):

            endpoint,
            location,
            feature_indicators: _,

What do you think about printing the feature indicators as a part of the CLI?

---

mullvad-management-interface/src/client.rs line 54 at r1 (raw file):

Previously, MarkusPettersson98 (Markus Pettersson) wrote…

Dropped FeatureIndicators from the DaemonEvent enum, think it turned out better!

Great work! 😄

[Serock3]

Reviewed 1 of 2 files at r5, 4 of 4 files at r6, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @hulthe)

---

mullvad-daemon/src/lib.rs line 1116 at r6 (raw file):

    /// Update the set of feature indicators.
    fn handle_feature_indicator_event(&self) {

Perhaps this function could take the new settings, convert them to feature indicators and only notify about a new tunnel state if they are different from new_indicators?

[MarkusPettersson98]

Done

Reviewable status: 13 of 15 files reviewed, 2 unresolved discussions (waiting on @hulthe and @Serock3)

[Serock3]

Reviewed 2 of 2 files at r7, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @hulthe)

---

mullvad-daemon/src/lib.rs line 1123 at r7 (raw file):

            let new_feature_indicators = self.get_feature_indicators();
            if *current_feature_indicators != new_feature_indicators {
                // Make sure to update the daemon's actual tunnel state. Otherwise feature indicator changes won't be persisted.

Good catch!

[Serock3]

Reviewed 4 of 4 files at r8, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @hulthe)

[Serock3]

Reviewed 1 of 1 files at r9, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @hulthe)