Avoid isVisible check, fixes DROID-1209 #6510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rawa
force-pushed
the
bottom-sheet-always-hide
branch
from
47f9d12 to
157a160
Compare
Pururun
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Rawa
force-pushed
the
bottom-sheet-always-hide
branch
from
157a160 to
93adda6
Compare
|
Fixes: DROID-1209 |
Fixes: DROID-1209
Rawa
force-pushed
the
bottom-sheet-always-hide
branch
from
93adda6 to
850ee7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes,
isVisiblewill return true, this will cause the bottom sheet to never be fully removed and the user stuck with an invisible overlay until they press back.This change is