Use std LazyLock instead of once_cell Lazy

[dlon]

The container needs to be updated to use Rust 1.80 before this can be merged.

---

This change is 

[MarkusPettersson98]

Reviewed all commit messages.
Reviewable status: 0 of 52 files reviewed, 1 unresolved discussion (waiting on @dlon)

---

talpid-core/src/firewall/linux.rs line 62 at r1 (raw file):

    LazyLock::new(|| CString::new("prerouting").unwrap());
static MANGLE_CHAIN_NAME: LazyLock<CString> = LazyLock::new(|| CString::new("mangle").unwrap());
static NAT_CHAIN_NAME: LazyLock<CString> = LazyLock::new(|| CString::new("nat").unwrap());

Nit: I think these uses of LazyLock could fairly easily be replaced by swapping to &CStr

static TABLE_NAME: &CStr = c"mullvad";
static IN_CHAIN_NAME: &CStr = c"input";
static OUT_CHAIN_NAME: &CStr = c"output";
static FORWARD_CHAIN_NAME: &CStr = c"forward";
static PREROUTING_CHAIN_NAME: &CStr = c"prerouting";
static MANGLE_CHAIN_NAME: &CStr = c"mangle";
static NAT_CHAIN_NAME: &CStr = c"nat";

Might apply for other uses of static CStrings as well

Code quote:

static TABLE_NAME: LazyLock<CString> = LazyLock::new(|| CString::new("mullvad").unwrap());
static IN_CHAIN_NAME: LazyLock<CString> = LazyLock::new(|| CString::new("input").unwrap());
static OUT_CHAIN_NAME: LazyLock<CString> = LazyLock::new(|| CString::new("output").unwrap());
static FORWARD_CHAIN_NAME: LazyLock<CString> = LazyLock::new(|| CString::new("forward").unwrap());
static PREROUTING_CHAIN_NAME: LazyLock<CString> =
    LazyLock::new(|| CString::new("prerouting").unwrap());
static MANGLE_CHAIN_NAME: LazyLock<CString> = LazyLock::new(|| CString::new("mangle").unwrap());
static NAT_CHAIN_NAME: LazyLock<CString> = LazyLock::new(|| CString::new("nat").unwrap());

[dlon]

Reviewable status: 0 of 54 files reviewed, all discussions resolved

---

talpid-core/src/firewall/linux.rs line 62 at r1 (raw file):

Previously, MarkusPettersson98 (Markus Pettersson) wrote…

Nit: I think these uses of LazyLock could fairly easily be replaced by swapping to &CStr

static TABLE_NAME: &CStr = c"mullvad";
static IN_CHAIN_NAME: &CStr = c"input";
static OUT_CHAIN_NAME: &CStr = c"output";
static FORWARD_CHAIN_NAME: &CStr = c"forward";
static PREROUTING_CHAIN_NAME: &CStr = c"prerouting";
static MANGLE_CHAIN_NAME: &CStr = c"mangle";
static NAT_CHAIN_NAME: &CStr = c"nat";

Might apply for other uses of static CStrings as well

Great idea!

[MarkusPettersson98]

Reviewed 27 of 52 files at r1, 31 of 31 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dlon)

---

talpid-wireguard/src/lib.rs line 16 at r2 (raw file):

use std::io;
#[cfg(target_os = "linux")]
use std::sync::LazyLock;

Nit The Linux-specific imports could be grouped to reduce visual clutter a bit

#[cfg(target_os = "linux")]
use std::{env, sync::LazyLock};
#[cfg(windows)]
use std::io;

Code quote:

#[cfg(target_os = "linux")]
use std::env;
#[cfg(windows)]
use std::io;
#[cfg(target_os = "linux")]
use std::sync::LazyLock;

[MarkusPettersson98]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved