Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match on success message for instrumented tests #6541

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Jul 30, 2024


This change is Reviewable

Copy link

linear bot commented Jul 30, 2024

@Rawa Rawa changed the title Match on success message Match on success message for instrumented tests Jul 30, 2024
@Pururun Pururun added the Android Issues related to Android label Jul 31, 2024
@Rawa Rawa self-assigned this Jul 31, 2024
@Rawa Rawa force-pushed the better-detection-for-faulty-screen-tests-droid-1211 branch 2 times, most recently from 9331db8 to 5d505af Compare July 31, 2024 12:41
@Rawa Rawa requested a review from Pururun July 31, 2024 12:41
@Rawa Rawa marked this pull request as ready for review July 31, 2024 12:41
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)


android/scripts/run-instrumented-tests-locally.sh line 12 at r1 (raw file):

REPORT_DIR=$(mktemp -d)
export REPORT_DIR
"$SCRIPT_DIR"/run-instrumented-tests.sh --test-type app --infra-flavor prod --billing-flavor oss

@Rawa Rawa force-pushed the better-detection-for-faulty-screen-tests-droid-1211 branch from 5d505af to 19530f1 Compare July 31, 2024 12:47
@Rawa Rawa merged commit 74ab3c0 into main Jul 31, 2024
21 of 22 checks passed
@Rawa Rawa deleted the better-detection-for-faulty-screen-tests-droid-1211 branch July 31, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants